Ooh good a kit thread!
Adidas, Puma and Nike are pretty crap unless you're an elite club. Macron do a decent job, but can look a little amateurish.
For me, it's between Umbro for their quality and finish and Kappa for their designs. Look at these beauties..