Been to Historic Dockyard a few times, last time was 2013, but I don't remember the submarine.
HMS Warrior is worth looking at and the boys will enjoy Action Stations.
Also remember a boat trip that gets up close to the navy ships in the harbour.
We got a family ticket which you can use on...